search

twitter / hogan.js

A compiler for the Mustache templating language
http://twitter.github.io/hogan.js
Apache License 2.0
5.14k stars 431 forks source link

Allow implicit iteration over the root context element #220

Open Mr0grog opened 9 years ago

Mr0grog commented 9 years ago

This fixes #154 and generally matches Mustache.js’s behavior. Since there’s no test for this in the Mustache spec (see https://github.com/mustache/spec/issues/87), I’ve added a unit test for it.

It’d be really nice to have this added in—I recently dealt with a confusing moment when transitioning some Mustache templates that used this pattern to Hogan. If the bug is any indication, it’s tripped up others, too.

Mr0grog commented 9 years ago

Looks like the dependencies of some of the dependencies require Node 0.10+, so Travis is no longer able to complete a build on Node 0.6, which is what is specified in the .travis.yml. I can update it to 0.10 in this PR if you’d like.

Mr0grog commented 9 years ago

Anything I can do to help get this merged in? It’s been sitting for a week and a half and would be really great to have fixed.

Mr0grog commented 9 years ago

Hi there, just checking in on this PR. Is anybody maintaining Hogan anymore?

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

Mr0grog commented 5 years ago

Taking that as a sign of some more attention here, but is this PR still relevant? (I haven’t really been using Hogan in the last couple years and may not be up to speed.) Happy to sign the CLA if so.