search

twitter / pelikan

Pelikan is Twitter's unified cache backend
Apache License 2.0
1.94k stars 176 forks source link

Momento proxy fixes #470

Closed eaddingtonwhite closed 2 years ago

eaddingtonwhite commented 2 years ago

Docker build was failing with following error.

 => [cargo-build 5/8] RUN apt-get install -y clang                                                                                                                                                                                                      17.5s
 => ERROR [cargo-build 6/8] RUN mkdir .cargo                                                                                                                                                                                                             0.3s
------
 > [cargo-build 6/8] RUN mkdir .cargo:
#14 0.251 mkdir: cannot create directory '.cargo': File exists
------
executor failed running [/bin/sh -c mkdir .cargo]: exit code: 1

This fixes the docker build since .cargo directory is checked into the repo root now we don't need to create that directory in Docker build anymore.

Validated this locally with docker build . as well.

Published a new version of container to Docker hub from our fork after fix from release workflow and tested with new Redis protocol functionality as well working great!

$ docker run -d \
   -p 6379:6379 \
   -p 11211:11211 \
   -p 9999:9999 \
   -e MOMENTO_AUTHENTICATION=eyJ***  \
   gomomento/momento-proxy

$ redis-cli -h 0.0.0.0 -p 6379 SET FOO BAR
OK
$ redis-cli -h 0.0.0.0 -p 6379 GET FOO
"BAR"

Also fixes broken link in README that broke when we 🪓 the rust directory under src.