search

twitter / rezolus

Systems performance telemetry
Apache License 2.0
1.56k stars 116 forks source link

fix wrong config of example.toml #264

Closed loyispa closed 2 years ago

loyispa commented 2 years ago

Problem

When i try to uncomment the percentiles config of example.toml, the process just exit with the prompt:

invalid type: string "1.0", expected f64 for key samplers.cpu.percentiles at line 65 column 3

After discarding the double quotos of the numbers, the program runs normaly. It's just a minor problem, however it does mislead users who use it for the first time. Maybe we should correct it.

Solution

Correct the example.

Result

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

brayniac commented 2 years ago

Good catch! Thanks for opening a PR for this. I'll merge after successful CI run.