https://twitter.github.io/scala_school/ lost its styling

twitter / scala_school

Lessons in the Fundamentals of Scala

https://twitter.github.io/scala_school

Apache License 2.0

3.71k stars 1.13k forks source link

https://twitter.github.io/scala_school/ lost its styling #204

Closed stefanlance closed 6 years ago

stefanlance commented 6 years ago

https://github.com/twitter/scala_school/pull/202 was recently merged, after which I pulled from master and ran make publish, as the readme says. This deployed the latest version of the site except it lost all its styling in production.

Steps to reproduce:

request write access to this repository
clone master and ensure the dependencies listed in the readme are installed
run make serve to see the local site with the proper styling
run make publish to see the production site without the styling

francis36012 commented 6 years ago

Requests for style.css, bootstrap-1.10.min.css and small-screens.css all return 404. Base URL of these requests is https://twitter.github.io

akanshmurthy commented 6 years ago

Just a hunch but it looks like this commit (https://github.com/twitter/scala_school/commit/d71b3324c1ea8e67f0b4353c8bd8d7f5f64a00df) created the default/post layouts as html instead of textile files inside the _layouts directory. Now, make, which builds to the web.out directory, doesn't seem to be creating the default/post files.

In any case, how do I claim/get assigned to this ticket? I'd like to work on it.

vincentfree commented 6 years ago

@akanshmurthy you could have already made a pull request right? but i see that #205 already did that.

vincentfree commented 6 years ago

Looks like he isn't done yet, the homepage is ok but the rest still lacks styling

akanshmurthy commented 6 years ago

Seems like there are multiple PRs open for this one issue probably because of the same problem I faced... which is that you can't assign someone to an issue leading to multiple people working on the same issue... which leads me back to my original question -> how can can we claim issues?? :)

taverasmisael commented 6 years ago

@akanshmurthy I've seen across Github some repos with bots to manage claiming issues with commands like Slack (/request, for example) and not leading anyone who was not assigned to PR on this issue. If the person does not respond in a determined time the issue is reseted and is open to being reassigned. I think we could implement one here 😉

taverasmisael commented 6 years ago

@vincentfree I saw the #205 PR and the problem relayed on he fixing only the main layout, I noticed this and changed the path for styles on all of them on my #211 as you can see in the GH is on my forked repo