Fix stylesheet paths. fix #204 #205

twitter / scala_school

Lessons in the Fundamentals of Scala

https://twitter.github.io/scala_school

Apache License 2.0

3.71k stars 1.13k forks source link

Fix stylesheet paths. fix #204 #205 #211

Closed taverasmisael closed 6 years ago

taverasmisael commented 6 years ago

By removing the '/' at the beginning of styles URL in both post and default layout seem to solve the styles issues related to #204. In #205 is fixed but not in both layout files. I uploaded to my own GH-Page where you can see it working: https://taverasmisael.github.io/scala_school/

PD: I made these changes before realizing it was already a PR with these, but as seem on #204 the styles still not working.

CLAassistant commented 6 years ago

All committers have signed the CLA.

vincentfree commented 6 years ago

Looks good again hope it gets excepted soon so the main page also gets its styling back

agargenta commented 6 years ago

Thanks @vincentfree!

kevin-lee commented 5 years ago

When can we have it released or deployed? It's still broken.

screen shot 2019-02-25 at 4 12 25 pm

vincentfree commented 5 years ago

Maybe someone needs to run a deploy script or something. Don't think a build had been triggert. I could check the resources of the current deployed build to see if the fix is actually online