twitter / scala_school

Lessons in the Fundamentals of Scala
https://twitter.github.io/scala_school
Apache License 2.0
3.71k stars 1.13k forks source link

Fixing CSS 404 errors #215

Closed aspctu closed 5 years ago

aspctu commented 5 years ago

Problem The current scala_school site located here has 404 errors when calling the CSS files. Solution PR #211 should have fixed this on the main site but the site needs to be rebuilt with the fix using make. This PR applies the fix and rebuilds the site as seen in the /web/ folder. Result The https://twitter.github.io/scala_school/ should no longer have CSS 404 errors and should render the CSS properly on the site.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 16 committers have signed the CLA.

:white_check_mark: stefanlance
:white_check_mark: marcelocenerine
:white_check_mark: taverasmisael
:white_check_mark: simeonf
:white_check_mark: asakaev
:white_check_mark: alanbato
:white_check_mark: aspctu
:x: benpence
:x: ggrossman
:x: m4jing
:x: nikitajz
:x: greexon
:x: qilab
:x: Fetiorin
:x: garciparedes
:x: agargenta


qilab seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.