twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

Refactor the cascading planning code out of Grouped #1670

Closed johnynek closed 7 years ago

johnynek commented 7 years ago

This is a follow on to #1666 to bring almost all of the cascading planning out of Grouped related to reduce steps. There is still a small bit which overlaps with CoGrouped, which will be moved after we tackle CoGrouped.

r? @fwbrasil @piyushnarang @ianoc

ianoc commented 7 years ago

all seems pretty lgtm, like all the sealed traits. Code looks nice and readable too 👍

(Overall these plots actually I think are making the planning code overall more readable so thats pretty awesome too)