Revert memory estimator changes on 0.17.x branch

twitter / scalding

A Scala API for Cascading

http://twitter.com/scalding

Apache License 2.0

3.5k stars 708 forks source link

Revert memory estimator changes on 0.17.x branch #1704

Closed piyushnarang closed 7 years ago

piyushnarang commented 7 years ago

Reverted the commit that brought in the memory estimator changes into 0.17.x (https://github.com/twitter/scalding/pull/1700). This will allow us to cut a 0.17.2 release that is binary & source compatible.

johnynek commented 6 years ago

we really need a migration guide here.

People configure reducer estimators with reflection (class names). I'm afraid this is a major pain now since compilation failures won't catch it.

Also, it is not clear what ReducerEstimator should be replaced with. Estimator? Can you make a short set of comments @dieu ?

dieu commented 6 years ago

@johnynek sorry for the delay, I will on this today and give you more detail about this.