search

twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

Fix AddExplicitFork #1753

Closed johnynek closed 6 years ago

johnynek commented 6 years ago

this closes #1747

The problem is that we were sometimes had (a -> b -> ...) and replaces b with a -> b which makes an infinite loop at a.

The solution is just writing the rule more carefully, but it is much more complex.

See the example test we added to dagon: https://github.com/stripe/dagon/pull/18

cc @fwbrasil @non

johnynek commented 6 years ago

@ianoc @fwbrasil any chance for a review?

ianoc commented 6 years ago

sorry i had read through this mostly before. LGTM

fwbrasil commented 6 years ago

I'm still familiarizing with dagon and the new ast/rules, but LGTM