Closed johnynek closed 6 years ago
this closes #1747
The problem is that we were sometimes had (a -> b -> ...) and replaces b with a -> b which makes an infinite loop at a.
(a -> b -> ...)
b
a -> b
a
The solution is just writing the rule more carefully, but it is much more complex.
See the example test we added to dagon: https://github.com/stripe/dagon/pull/18
cc @fwbrasil @non
@ianoc @fwbrasil any chance for a review?
sorry i had read through this mostly before. LGTM
I'm still familiarizing with dagon and the new ast/rules, but LGTM
this closes #1747
The problem is that we were sometimes had
(a -> b -> ...)
and replacesb
witha -> b
which makes an infinite loop ata
.The solution is just writing the rule more carefully, but it is much more complex.
See the example test we added to dagon: https://github.com/stripe/dagon/pull/18
cc @fwbrasil @non