twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

Add a setting to skip null counters #1759

Closed johnynek closed 6 years ago

johnynek commented 6 years ago

We have observed NPEs for null counters at least two companies using scalding. We have not root-caused this issue or found a good fix, but previously set to ignore all null counters.

Since some people rely on counters this is not a great plan, so instead this patch makes ignoring an opt-in behavior.

closes #1732

related to #1716 and #1726

cc @tdyas @rstewart this will change the default to error on null again. When you upgrade you will need to opt in to silently dropping counters using scalding.counters.skipnull=true

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

ianoc commented 6 years ago

lgtm