search

twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

Give good equality to TupleConversion classes #1781

Closed johnynek closed 6 years ago

johnynek commented 6 years ago

closes #1739

This changes the generated tuple conversion code to be case classes. This gives us nice toString, but more importantly it makes it safe to skip some .mapTo operations in the CascadingBackend that are only reformatting the tuple.

There may be slightly more room for optimization, but this should be an improvement all around.

johnynek commented 6 years ago

ptal @piyushnarang

ianoc commented 6 years ago

looks great to me, even just to have better equality and toString are good reasons for the change. Perf optimization is nice too ofc.

lgtm

piyushnarang commented 6 years ago

Not super familiar with this part of the code but from what I understand, looks good to me 👍

johnynek commented 6 years ago

Thanks for the review folks!