Closed johnynek closed 6 years ago
ptal @piyushnarang
looks great to me, even just to have better equality and toString are good reasons for the change. Perf optimization is nice too ofc.
lgtm
Not super familiar with this part of the code but from what I understand, looks good to me 👍
Thanks for the review folks!
closes #1739
This changes the generated tuple conversion code to be case classes. This gives us nice toString, but more importantly it makes it safe to skip some
.mapTo
operations in the CascadingBackend that are only reformatting the tuple.There may be slightly more room for optimization, but this should be an improvement all around.