Closed johnynek closed 6 years ago
@non @erik-stripe another in a similar vein of cleaning up types. Can you review this?
The test failure here seems unrelated, but real. Filed #1786 to run it down. Yay for property checks! I wish I had made these TypedPipe generators sooner!
LGTM 👍
This removes 4 totally general casts, and replaces them with one highly constrained casting function which should be safe for all of scalding uses.
This removes the need to audit each of these casts and consolidates the explanation as to the safety in one place.