twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

Consolidate a scalding-safe Ordering cast #1784

Closed johnynek closed 6 years ago

johnynek commented 6 years ago

This removes 4 totally general casts, and replaces them with one highly constrained casting function which should be safe for all of scalding uses.

This removes the need to audit each of these casts and consolidates the explanation as to the safety in one place.

johnynek commented 6 years ago

@non @erik-stripe another in a similar vein of cleaning up types. Can you review this?

johnynek commented 6 years ago

The test failure here seems unrelated, but real. Filed #1786 to run it down. Yay for property checks! I wish I had made these TypedPipe generators sooner!

non commented 6 years ago

LGTM 👍