search

twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.49k stars 703 forks source link

Improve rules, rule testing, and bump dagon #1803

Closed johnynek closed 6 years ago

johnynek commented 6 years ago

This seems to fix an issue with an infinite loop I was seeing that we were interpreting as it taking a long time.

I think when randomly making rules: one would change the graph in one way, the next would change it back, creating an infinite loop.

I seem to fix it by removing a rule from random selection. I also check that the standard rules don't loop infinitely.

ianoc-stripe commented 6 years ago

lgtm

non commented 6 years ago

lgtm 👍

johnynek commented 6 years ago

the only test that failed is the one that is fixed by #1805.

Merging since that one should fix it up.