search

twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.48k stars 704 forks source link

Remove dependency on macro-compat #1896

Closed xeno-by closed 5 years ago

xeno-by commented 5 years ago

In our experiments with supporting progressively bigger chunks of Twitter codebase with Rsc, we stumbled upon usage of macro annotations in Scalding.

At the moment, Rsc doesn't support macros (neither def macros, not macro annotations), so macro annotations present a problem for our experiments.

This pull request is specifically about the @bundle annotation from macro-compat.

It looks like this annotation was added in order to cross-compile between Scala 2.10 and Scala 2.11+ (since there are source-incompatible changes in the macro API between these versions). However, since this codebase no longer seems to support Scala 2.10, it looks like usages of @bundle (and macro-compat) can be safely removed. That would simplify our internal experiments with Rsc.

johnynek commented 5 years ago

did you mean we no longer support 2.10? We definitely do support 2.11.

xeno-by commented 5 years ago

@johnynek Yes, I meant this codebase no longer seems to support Scala 2.10. Thank you for noticing! Updated the comment.

johnynek commented 5 years ago

@xeno-by can rsc compile scalding now?

xeno-by commented 5 years ago

@johnynek I didn't try that yet.