twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

Add additional guards in `ReferencedClassFinder` #1931

Closed ttim closed 4 years ago

ttim commented 4 years ago

During upgrade to Scala 2.12.10 in Twitter we discovered illegal cyclic reference exception failing from scalaType.member(universe.stringToTermName(field.getName)).typeSignature code in ReferencedClassFinder.

In this PR I've guarded this code with the same check as we do for getClassType.

Unfortunately I wasn't able to replicate this failure is OSS easily so added this guard without failing test.

johnynek commented 4 years ago

Thanks for sending the PR!