search

twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

Update sbt to 1.5.6 #1939

Closed ttim closed 3 years ago

ttim commented 3 years ago

This PR updates sbt version to latest available one: 1.5.6.

I've updated sbt plugins versions to be compatible with newer version of sbt, as well as updates build.sbt to work successfully.

I'll follow up with two PRs: to move to scalafmt and mdoc plugins

johnynek commented 3 years ago

question: why not use the latest sbt?

ttim commented 3 years ago

question: why not use the latest sbt?

I've used last version which works with our sbt script, will follow up with upgrading it to most recent version.

ttim commented 3 years ago

question: why not use the latest sbt?

Updated to the latest available sbt version

johnynek commented 3 years ago

error: File /home/travis/build/twitter/scalding/docs/docs does not exist.

I think this may have to do with tut being disabled.

ttim commented 3 years ago

error: File /home/travis/build/twitter/scalding/docs/docs does not exist.

I think this may have to do with tut being disabled.

Yes. I'll follow up with docs fix, since it's already broken in develop, and that's not a regression.

There is one repl test which started to fail which I investigate currently.

ttim commented 3 years ago

@johnynek finally was able to figure out why repl test started to fail - travis enables batch mode for sbt runs...

I'm planning to follow up with mdoc & scalafmt in separate PRs, let me know if that's ok with you.