Support `sortedTake` in beam runner

twitter / scalding

A Scala API for Cascading

http://twitter.com/scalding

Apache License 2.0

3.48k stars 703 forks source link

Closed nownikhil closed 2 years ago

nownikhil commented 2 years ago

We flatten all the input PriorityQueues and construct a new PQ using the monoid provided. TESTS: Updated failing unit test

johnynek commented 2 years ago

Good lesson here: mutation, NOT EVEN ONCE!

tlazaro commented 2 years ago

I'm fine with landing this, how do we usually do it? 'Squash and merge' ?

johnynek commented 2 years ago

yes, squash and merge if you think it is ready. Looks good to me too.