search

twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

Add GitHub CI (migrate from Travis CI) #1963

Closed daniel-sudz closed 2 years ago

daniel-sudz commented 2 years ago

Screen Shot 2022-02-18 at 5 17 20 PM

Missing features from travis (follow-up PR work):

  1. build cache -- I think this is fair for a followup PR since it's not essential.
  2. Scala lib resolution on scald.rb is slow, constantly causing sbt re-resolution of classpath due to directory miss. Likely a small path tweak is needed in the future to speed it up. This is the logic for puts "#{dep} was not where it was expected, #{SCALA_LIB_DIR}...finding..."
CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

daniel-sudz commented 2 years ago

@nownikhil @tlazaro @ttim could I please get a review from someone with push-access? I think this is highly essential for any kind of work on this project

johnynek commented 2 years ago

are these still TODOs?

TODO: remove travis.yml, remove debug trigger.

If so, why? Can we remove the travis.yml now? What is the debug trigger?

daniel-sudz commented 2 years ago

@johnynek removed, thanks. For debug trigger I was referring to the trigger for the CI. I've set it to all for now: 

# run on all branches
on:
  pull_request:
    branches:
      - '**'
  push:
    branches:
      - '**'

since it's free for open source I don't see a reason to not just run it for everything.

johnynek commented 2 years ago

Thanks a lot for your help!

I'm going to merge.

We can follow with more improvements later.

Thanks again!

germanschnyder commented 2 years ago

Just curious, this work didn't update the main CI badge, right ?

johnynek commented 2 years ago

Nope. We forgot. PRs always welcome. ❤️