no op change to test publish and see if something breaks

[daniel-sudz]

added new line to readme @johnynek

[codecov-commenter]

Codecov Report

Merging #1984 (d2ef66a) into develop (e44f2f2) will increase coverage by 2.08%. The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #1984      +/-   ##
=============================================
+ Coverage      35.74%   37.82%   +2.08%     
- Complexity      1079     1123      +44     
=============================================
  Files            316      316              
  Lines          20941    21117     +176     
  Branches        2850     2921      +71     
=============================================
+ Hits            7485     7988     +503     
+ Misses         12557    12141     -416     
- Partials         899      988      +89     

Impacted Files	Coverage Δ
...rc/main/scala/com/twitter/scalding/TypedJson.scala	0.00% <0.00%> (ø)
...tter/scalding/db/macros/impl/JdbcFieldSetter.scala	0.00% <0.00%> (ø)
...lding/db/macros/impl/handler/DateTypeHandler.scala	0.00% <0.00%> (ø)
...ding/db/macros/impl/handler/AnnotationHelper.scala	0.00% <0.00%> (ø)
...ing/db/macros/impl/handler/StringTypeHandler.scala	0.00% <0.00%> (ø)
...ng/db/macros/impl/handler/NumericTypeHandler.scala	0.00% <0.00%> (ø)
.../db/macros/impl/ColumnDefinitionProviderImpl.scala	0.00% <0.00%> (ø)
...la/com/twitter/scalding/GeneratedConversions.scala	9.64% <0.00%> (+0.25%)	:arrow_up:
...src/main/scala/com/twitter/scalding/JsonLine.scala	72.97% <0.00%> (+0.75%)	:arrow_up:
.../src/main/scala/com/twitter/scalding/JobTest.scala	71.29% <0.00%> (+0.92%)	:arrow_up:
... and 49 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e44f2f2...d2ef66a. Read the comment docs.

[johnynek]

let's see if this publishes!

@daniel-sudz let's add a comment to the artifact we publish here (I hope a snapshot with a sha derived version).

[johnynek]

https://github.com/twitter/scalding/actions/runs/2142207323

queued...

[daniel-sudz]

hmmm looks like we still have a GPG issue. I wonder if this is related: https://github.com/sbt/sbt-pgp/issues/173

edit: we seem to have the latest version of sbt-pgp so unlikely

[johnynek]

[error] java.lang.RuntimeException: Failure running 'gpg --batch --pinentry-mode loopback --passphrase *** --detach-sign --armor --use-agent --output /home/runner/work/scalding/scalding/scalding-avro/target/scala-2.12/scalding-avro_2.12-0.16.1-RC2-360-ebbfeb71-SNAPSHOT.pom.asc /home/runner/work/scalding/scalding/scalding-avro/target/scala-2.12/scalding-avro_2.12-0.16.1-RC2-360-ebbfeb71-SNAPSHOT.pom'.  Exit code: 2

two issues:

1. it is trying to publish 0.16.1-RC2 which I think is very old. I think we want something like 0.18.0-RC2: https://search.maven.org/artifact/com.twitter/scalding-core_2.12
2. I can't see any particular error, but the flag they mention seems to be added.

I wonder if I somehow goofed up the secrets? I followed these instructions: https://typelevel.org/sbt-typelevel/secrets.html and did the last option:

gpg --armor --export-secret-keys $LONG_ID | base64

and set that as the the secret.

[daniel-sudz]

yes, let's push a new tag I can try to repro PGP issue locally with your command nothing obvious I can think of for now

[johnynek]

yeah, those pgp instructions are wrong, you don't want the trailing | base64 I think. I think you just want to copy the base64 output.

[johnynek]

I just updated the secret. We can try again. But we should fix the tag.

[daniel-sudz]

I also wonder if we need the PGP_PASSPHRASE the doc you linked seems to suggest that it is not required (only PGP_SECRET). If that isn't used we should remove it could be tripping up pgp

[johnynek]

cc @armanbilge (maintainer of sbt-typelevel: I think those instructions are double base64 encoding the keys, but I'm not sure since I haven't made it work yet).

I don't know? I added a passphrase to the key, but when I exported it maybe it removes it? idk.

[johnynek]

also, where do we need the tags? we do have a later tag:

https://github.com/twitter/scalding/tree/v0.18.0-RC1

[armanbilge]

If that isn't used we should remove it could be tripping up pgp

If your key is passphrased, you need it. If your key is not passphrased, then you should remove it.

One easy fix may just be to generate a new keypair using the helper: https://typelevel.org/sbt-typelevel/secrets.html#option-1-generate-a-key-pair-in-your-browser

[daniel-sudz]

@johnynek I will make a PR to remove passphrase it seems redundant for our purpose let's use the generator as suggested above

[johnynek]

Wait well, I made a passphrased key and used the base64 encoding the first time and it didn't work?

[armanbilge]

Ummm ... is this project using sbt-typelevel? None of those instructions apply if it's not ...

[daniel-sudz]

yeah we are not using typelevel I was meaning to mention that. We use the base plugin: addSbtPlugin("com.github.sbt" % "sbt-release" % "1.1.0") addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.1.2")

the environment variable should be the same though so I assume the generator on that site should still work for us

[armanbilge]

Yeah, don't know why I was pinged, I have no stake in anything here :(

[daniel-sudz]

@johnynek I think the situation is this:

with https://github.com/sbt/sbt-release, it just forwards to sbt-pgp which dosn't handle the env variables nicely we can use https://github.com/sbt/sbt-ci-release that should handle everything nicely

the situation with typelevel was that it would require a lot of changes for all of our config setups so it didn't seem worth it

[johnynek]

Sorry @armanbilge i pinged you because I thought there may be a typo in your instructions I copied. I now realize that like most things in scala build it is massively bespoke and it appears there is a ton of diversity probably for no sane reason except publishing was never made excellent in sbt by default.

Sorry for my mistake on guessing your instructions may have a typo.

[daniel-sudz]

https://github.com/twitter/scalding/pull/1985