search

twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

FlowState can probably be removed by subclassing FlowDef #572

Open johnynek opened 11 years ago

johnynek commented 11 years ago

A package private FlowDef subclass that keeps any scalding specific state is probably a better way to go.

https://github.com/twitter/scalding/blob/develop/scalding-core/src/main/scala/com/twitter/scalding/FlowState.scala

johnynek commented 11 years ago

But this would be an issue for people using the FlowDef in their API. Ultimately, exposing FlowDef was probably a mistake. Not sure if fixing it with a scalding.FlowDef and an implicit from/to that to cascading could work. Possibly a 0.10. idea.

johnynek commented 10 years ago

related to #685