search

twitter / scalding

A Scala API for Cascading
http://twitter.com/scalding
Apache License 2.0
3.5k stars 706 forks source link

UnpackagedAvroSource and PackagedAvroSource objects don't pass implicits #899

Open ittayd opened 10 years ago

ittayd commented 10 years ago

Both UnpackagedAvroSource and PackageAvroSource case classes expect a TupleSetter and TupleConverter implicits. Yet the companion objects don't supply it. PackagedAvroSource passes TupleConverter only while UnpackagedAvroSource passes none. If they are not needed, maybe remove them from the declaration of the case classes?

ccsevers commented 10 years ago

I'm going to be gone for a week starting tomorrow but I can take a look at this when I get back.

Thanks!

mcanlas commented 8 years ago

Greetings from CodeTriage. Is this still an active issue?

There aren't any classes in master by these names. Maybe UnpackedAvroSource and PackedAvroSource?