search

twitter / scoot

Scoot is a distributed task runner, supporting both a proprietary API and Bazel's Remote Execution.
Apache License 2.0
349 stars 48 forks source link

adding logging for cluster update issue. This is a branch off 67439c… #552

Closed JeanetteBruno closed 3 years ago

JeanetteBruno commented 3 years ago

added logging to help debug delayed cluster update issue. This branch's parent was 67439c not mater.

Do not merge this branch!!!!!

codecov-commenter commented 3 years ago

Codecov Report

Merging #552 (22dd8bc) into master (67439c9) will increase coverage by 0.03%. The diff coverage is 79.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   54.33%   54.37%   +0.03%     
==========================================
  Files         120      120              
  Lines        8641     8659      +18     
==========================================
+ Hits         4695     4708      +13     
- Misses       3443     3446       +3     
- Partials      503      505       +2
Impacted Files Coverage Δ
cloud/cluster/state.go 89.28% <0.00%> (-3.31%) :arrow_down:
scheduler/server/stateful_scheduler.go 62.50% <0.00%> (-0.09%) :arrow_down:
cloud/cluster/cluster.go 90.32% <83.33%> (-2.28%) :arrow_down:
scheduler/server/cluster_state.go 85.63% <87.50%> (+0.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67439c9...22dd8bc. Read the comment docs.

JeanetteBruno commented 3 years ago

abandoning pr, this was a temporary change to collect data. pr 556 resulted from the analysis of the logging.