search

twitter / scoot

Scoot is a distributed task runner, supporting both a proprietary API and Bazel's Remote Execution.
Apache License 2.0
349 stars 48 forks source link

Don't return failed status on ingestion failure #563

Closed ryancouto closed 3 years ago

ryancouto commented 3 years ago

This can happen due to external failures. We still have a reference to the log files on the worker instance, and know the exit code of the task. We can just log the error and return that exit code.

codecov-commenter commented 3 years ago

Codecov Report

Merging #563 (27e9563) into master (100234d) will increase coverage by 0.07%. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
+ Coverage   55.11%   55.18%   +0.07%     
==========================================
  Files         119      119              
  Lines        8599     8604       +5     
==========================================
+ Hits         4739     4748       +9     
+ Misses       3345     3342       -3     
+ Partials      515      514       -1
Impacted Files Coverage Δ
runner/runners/invoke.go 50.00% <25.00%> (-0.36%) :arrow_down:
cloud/cluster/node.go 60.86% <0.00%> (+4.34%) :arrow_up:
cloud/cluster/cluster.go 85.48% <0.00%> (+11.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 100234d...27e9563. Read the comment docs.