search

twitter / scoot

Scoot is a distributed task runner, supporting both a proprietary API and Bazel's Remote Execution.
Apache License 2.0
349 stars 48 forks source link

re-checkout even if we're already on the correct branch #567

Closed ryancouto closed 3 years ago

ryancouto commented 3 years ago

This fixes a bug where if a snapshot is currently checked out on a worker & the worker receives a new task with the same snapshot, we immediately run the task without modification to the working directory. This is an issue if the previous task has modified the working state at all, and can lead to inconsistent results.

codecov-commenter commented 3 years ago

Codecov Report

Merging #567 (1230602) into master (1007c72) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
+ Coverage   55.15%   55.21%   +0.06%     
==========================================
  Files         119      119              
  Lines        8648     8640       -8     
==========================================
+ Hits         4770     4771       +1     
+ Misses       3359     3355       -4     
+ Partials      519      514       -5
Impacted Files Coverage Δ
snapshot/git/gitdb/db.go 61.90% <ø> (ø)
snapshot/git/gitdb/checkout.go 41.30% <100.00%> (+1.30%) :arrow_up:
scheduler/domain/generators.go 71.64% <0.00%> (+4.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1007c72...1230602. Read the comment docs.