search

twitter / scoot

Scoot is a distributed task runner, supporting both a proprietary API and Bazel's Remote Execution.
Apache License 2.0
349 stars 48 forks source link

Jbruno/remove ice from worker #570

Closed JeanetteBruno closed 2 years ago

JeanetteBruno commented 2 years ago

eliminate worker's use of ice.

was also able to eliminate worker config stuff since worker doesn't use any config structure.

codecov-commenter commented 2 years ago

Codecov Report

Merging #570 (cc9be0a) into master (91fd2af) will increase coverage by 0.04%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   55.18%   55.22%   +0.04%     
==========================================
  Files         119      118       -1     
  Lines        8640     8635       -5     
==========================================
+ Hits         4768     4769       +1     
+ Misses       3356     3352       -4     
+ Partials      516      514       -2
Impacted Files Coverage Δ
scheduler/setup/workers.go 0.00% <ø> (ø)
worker/starter/server.go 0.00% <ø> (ø)
worker/starter/start_server.go 0.00% <0.00%> (ø)
cloud/cluster/node.go 60.86% <0.00%> (+4.34%) :arrow_up:
cloud/cluster/cluster.go 85.48% <0.00%> (+11.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91fd2af...cc9be0a. Read the comment docs.