search

twitter / scoot

Scoot is a distributed task runner, supporting both a proprietary API and Bazel's Remote Execution.
Apache License 2.0
349 stars 48 forks source link

remove bazel remexec #582

Closed dgassaway closed 2 years ago

dgassaway commented 2 years ago

pain

There are thrift API changes here, which means this is potentially breaking, so I won't land it until the right path is laid out ini that regard.

codecov-commenter commented 2 years ago

Codecov Report

Merging #582 (b666b6d) into master (5bb3bf6) will increase coverage by 3.50%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   54.90%   58.41%   +3.50%     
==========================================
  Files         122      101      -21     
  Lines        8720     6651    -2069     
==========================================
- Hits         4788     3885     -903     
+ Misses       3413     2436     -977     
+ Partials      519      330     -189
Impacted Files Coverage Δ
cleaner/updater.go 0.00% <ø> (ø)
runner/runner.go 84.61% <ø> (+11.28%) :arrow_up:
runner/status.go 29.03% <ø> (+0.90%) :arrow_up:
scheduler/setup/api.go 0.00% <0.00%> (ø)
snapshot/bundlestore/server.go 0.00% <ø> (ø)
snapshot/bundlestore/setup.go 0.00% <0.00%> (ø)
worker/domain/api.go 80.83% <ø> (-0.92%) :arrow_down:
worker/starter/start_server.go 0.00% <ø> (ø)
runner/runners/invoke.go 67.73% <100.00%> (+18.31%) :arrow_up:
scheduler/api/thrift/get_status.go 94.11% <100.00%> (-0.09%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bb3bf6...b666b6d. Read the comment docs.