search

twitter / scoot

Scoot is a distributed task runner, supporting both a proprietary API and Bazel's Remote Execution.
Apache License 2.0
349 stars 48 forks source link

Added interface for log uploading by workers, replacing ingesting bundles #586

Closed harshita-chaudhary closed 2 years ago

harshita-chaudhary commented 2 years ago

Existing way of uploading logs: create a snapshot of log directory and upload to bundlestore Updated way: upload logs directly to a permanent storage by implementing LogUploader, skipping output snapshot creation and ingestion

codecov-commenter commented 2 years ago

Codecov Report

Merging #586 (6213ba3) into master (0f91e72) will increase coverage by 0.09%. The diff coverage is 84.48%.

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   58.60%   58.70%   +0.09%     
==========================================
  Files         101      102       +1     
  Lines        6651     6637      -14     
==========================================
- Hits         3898     3896       -2     
+ Misses       2424     2418       -6     
+ Partials      329      323       -6
Impacted Files Coverage Δ
worker/starter/start_server.go 0.00% <0.00%> (ø)
runner/runners/invoke.go 73.97% <83.33%> (+6.24%) :arrow_up:
runner/runners/log_uploader.go 100.00% <100.00%> (ø)
runner/runners/queue.go 77.27% <100.00%> (ø)
scheduler/server/task_runner.go 84.78% <0.00%> (-5.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f91e72...6213ba3. Read the comment docs.