Closed dependabot[bot] closed 4 years ago
claassistantio
commented
4 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
codecov-io
commented
4 years ago Merging #323 into develop will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## develop #323 +/- ##
========================================
Coverage 83.95% 83.95%
========================================
Files 77 77
Lines 3541 3541
Branches 199 199
========================================
Hits 2973 2973
Misses 568 568Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update fcb800f...8fdc8ae. Read the comment docs.
caniszczyk
commented
4 years ago Merging #323 into develop will not change coverage by
%. The diff coverage isn/a.
@@ Coverage Diff @@
## develop #323 +/- ##
========================================
Coverage 83.95% 83.95%
========================================
Files 77 77
Lines 3541 3541
Branches 199 199
========================================
Hits 2973 2973
Misses 568 568 Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update fcb800f...8fdc8ae. Read the comment docs.
ryanoneill
commented
4 years ago While this is helpful, upgrading the version of thrift used company wide requires much more than just this change. I'm going to close this pull request for that reason.
dependabot[bot]
commented
4 years ago OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
Bumps libthrift from 0.10.0 to 0.12.0.
Release notes
*Sourced from [libthrift's releases](https://github.com/apache/thrift/releases).* > ## Version 0.12.0 > # Thrift v0.12.0 > > ## New Languages > * Common LISP (cl) > * Swift > * Typescript (nodets) > > ## Complete Release Notes > > https://github.com/apache/thrift/blob/0.12.0/CHANGESChangelog
*Sourced from [libthrift's changelog](https://github.com/apache/thrift/blob/master/CHANGES.md).* > ## 0.12.0 > > Released 2019-JAN-04 > > ### New Languages > - Common LISP (cl) > - Swift > - Typescript (nodets) > > ### Deprecated Languages > - C++03/C++98 (move to C++11) > - Cocoa (move to Swift) > > ### Breaking Changes (since 0.11.0) > - [THRIFT-4529](https://issues.apache.org/jira/browse/THRIFT-4529) - Rust enum variants are now camel-cased instead of uppercased to conform to Rust naming conventions > - [THRIFT-4448](https://issues.apache.org/jira/browse/THRIFT-4448) - Support for golang 1.6 and earlier has been dropped. > - [THRIFT-4474](https://issues.apache.org/jira/browse/THRIFT-4474) - PHP now uses the PSR-4 loader by default instead of class maps. > - [THRIFT-4532](https://issues.apache.org/jira/browse/THRIFT-4532) - method signatures changed in the compiler's t_oop_generator. > - [THRIFT-4648](https://issues.apache.org/jira/browse/THRIFT-4648) - The C (GLib) compiler's handling of namespaces has been improved. > > ### Known Issues (Blocker or Critical) > - [THRIFT-4037](https://issues.apache.org/jira/browse/THRIFT-4037) - build: use a single build system for thrift > - [THRIFT-4119](https://issues.apache.org/jira/browse/THRIFT-4119) - build: bootstrap.sh is missing from source tarball > - [THRIFT-3289](https://issues.apache.org/jira/browse/THRIFT-3289) - csharp: socket exhaustion in csharp implementation > - [THRIFT-3029](https://issues.apache.org/jira/browse/THRIFT-3029) - cocoa: Getters for fields defined with uppercase names do not work > - [THRIFT-3325](https://issues.apache.org/jira/browse/THRIFT-3325) - cocoa: Extended services aren't subclasses in generated Cocoa > - [THRIFT-4116](https://issues.apache.org/jira/browse/THRIFT-4116) - cocoa: Thrift de-capitalizes the name of IsSet property in Cocoa > - [THRIFT-3877](https://issues.apache.org/jira/browse/THRIFT-3877) - cpp: the http implementation is not standard; interop with other languages is spotty at best > - [THRIFT-4180](https://issues.apache.org/jira/browse/THRIFT-4180) - cpp: Impossible to build Thrift C++ library for Android (NDK) > - [THRIFT-4384](https://issues.apache.org/jira/browse/THRIFT-4384) - cpp: Using multiple async services simultaneously is not thread-safe > - [THRIFT-3108](https://issues.apache.org/jira/browse/THRIFT-3108) - haskell: Defaulted struct parameters on a service generates invalid Haskell > - [THRIFT-3990](https://issues.apache.org/jira/browse/THRIFT-3990) - nodejs: Exception swallowed by deserialization function > - [THRIFT-4214](https://issues.apache.org/jira/browse/THRIFT-4214) - nodejs: mapCommits
- [`384647d`](https://github.com/apache/thrift/commit/384647d290e2e4a55a14b1b7ef1b7e66293a2c33) Version 0.12.0 - [`9b75e4f`](https://github.com/apache/thrift/commit/9b75e4fe745a9b08e6ccdc0998ec7a69272f5b4c) THRIFT-4680: fix up std::min, std::max, and numeric limits min/max on Windows... - [`56ac72e`](https://github.com/apache/thrift/commit/56ac72e74ae354c286c41f5d5a3c0b8723feb587) Update a couple of our m4 files for autoconf - [`33772b7`](https://github.com/apache/thrift/commit/33772b7d78dc3e73154f1942320e1a6ef3301e1b) Add node.ts to the languages markdown - [`f4b1785`](https://github.com/apache/thrift/commit/f4b17857db4a7ff6885d22535b0e9b963af49397) Merge pull request [#1646](https://github-redirect.dependabot.com/apache/thrift/issues/1646) from allengeorge/rustfmt_10 - [`ef7a189`](https://github.com/apache/thrift/commit/ef7a18970f309632e3a3015ac1c659d72d36967b) Reformat rust code with rustfmt 1.0 - [`2b7365c`](https://github.com/apache/thrift/commit/2b7365c54f823013cc6a4760798051b22743c103) THRIFT-4659: Fix race when closing server socket ([#1645](https://github-redirect.dependabot.com/apache/thrift/issues/1645)) - [`44ee32c`](https://github.com/apache/thrift/commit/44ee32cef57cbbd0ad62dfa026f0ee5e746f5c2b) Fix c++98 build - [`e6e7e62`](https://github.com/apache/thrift/commit/e6e7e62981e285d6d7e023a618be3bafa514edae) Correct c++17 definition - [`db61f10`](https://github.com/apache/thrift/commit/db61f10497bcf069da03537629dcc79b0523ebe4) Fix build with old c++ - Additional commits viewable in [compare view](https://github.com/apache/thrift/compare/0.10.0...v0.12.0)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/twitter/scrooge/network/alerts).