search

twitter / scrooge

A Thrift parser/generator
http://twitter.github.io/scrooge/
Apache License 2.0
793 stars 247 forks source link

Interested in adding support for typescript? #339

Open alexduf opened 3 years ago

alexduf commented 3 years ago

Hi everyone,

The Guardian has developed a Typescript extension to the scrooge compiler, would you be interested in merging it upstream?

I can see the scrooge compiler already support a number of languages, and I've noticed there was a generic "hook" enabling anyone to add support for any language. For our own needs at the Guardian we took advantage of that hook and implemented a Typescript backend for the scrooge compiler. We're happy to keep the two projects separate, but I wondered if there was any appetite from Twitter or any other users to seeing it pushed upstream.

More info: https://github.com/guardian/scrooge-extras

Let me know your thoughts!

mosesn commented 3 years ago

@alexduf thanks for reaching out! I'm glad to hear that you were able to add support for Typescript! In the past, we've been cautious about accepting contributions that we don't have the expertise to maintain ourselves, because we're worried that we won't be very good maintainers of them. I think that Typescript falls under that category too.

However, maybe a good approach here would be to add a link in the Scrooge docs to guardian/scrooge-extras so that potential users know where to look?

alexduf commented 3 years ago

Thanks for your reply @mosesn!

That makes complete sense to me, I would need to do some cleanup of our documentation and sbt plugin as they are currently very Guardian centric.

Would it be alright if I re-opened this conversation once we're ready to be linked in the scrooge docs?

mosesn commented 3 years ago

@alexduf yes please!