mhrheaume commented 2 years ago

Summary: Problem

SwiftGeneratorSpec was failing when being run through SBT due to an NPE while setting up the tests. Upon further investigation, this NPE was occuring because the swift test resources were not being included as a resource directory under SBT, resulting in a null return value from ClassLoader#getResource().

Solution

These test resource files don't actually need to be under the thrift/ directory, as they are only used in the context of SwiftGeneratorSpec, so this patch moves them to the standard resource/ directory. This makes the resources available in tests without having to do any special resource declaration in build files.

CLAassistant commented 2 years ago

All committers have signed the CLA.

codecov-commenter commented 2 years ago

Codecov Report

Merging #353 (0ebc81b) into develop (aa83a3f) will decrease coverage by 0.13%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #353      +/-   ##
===========================================
- Coverage    54.74%   54.61%   -0.14%     
===========================================
  Files           43       44       +1     
  Lines         1233     1236       +3     
  Branches        89       86       -3     
===========================================
  Hits           675      675              
- Misses         558      561       +3

Impacted Files	Coverage Δ
.../scala/com/twitter/scrooge/ThriftStructCodec.scala	`0.00% <0.00%> (ø)`
...ala/com/twitter/scrooge/ThriftStructMetaData.scala	`50.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8184640...0ebc81b. Read the comment docs.

twitter / scrooge

scrooge: Fixed SwiftGeneratorSpec with SBT. #353

Codecov Report