search

twitter / scrooge

A Thrift parser/generator
http://twitter.github.io/scrooge/
Apache License 2.0
793 stars 247 forks source link

WIP: Upgrade to libthrift 0.19.0 #367

Open rtyley opened 7 months ago

rtyley commented 7 months ago

Scrooge's TArrayByteTransport and TReusableMemoryTransport classes both extend libthrift's abstract org.apache.thrift.transport.TTransport class. That class gained 3 new abstract members with https://github.com/apache/thrift/pull/2191 (September 2020), released with libthrift v0.14.0 (February 2021). Consequently, both classes currently fail to compile, due to missing implementations for these methods:

def checkReadBytesAvailable(x$1: Long): Unit = ???
def getConfiguration(): org.apache.thrift.TConfiguration = ???
def updateKnownMessageSize(x$1: Long): Unit = ???

Note that Snyk PR https://github.com/twitter/scrooge/pull/357 updates only one of several files that needs to be updated for a libthrift upgrade, and the most important file is probably build.sbt, not demos/scrooge-maven-demo/pom.xml.

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.