search

twitter / storehaus

Storehaus is a library that makes it easy to work with asynchronous key value stores
Apache License 2.0
465 stars 92 forks source link

Feature/storehaus cassandra only #282

Open ghost opened 9 years ago

ghost commented 9 years ago

As discussed in #211

johnynek commented 9 years ago

@travisbrown can you review the shapeless usage here? I know very little shapeless.

ianoc commented 9 years ago

I think I'd rather we make a storehaus-contrib's repo and move these sorts of stores there. Any upgrades to support new scala versions to the core get blocked on lots of these external stores with questionable external support around them. I'd rather we have a core which we can be very confident about and the contrib repo people can update or not update as they like. I'm afraid of our builds being blocked by say flaky tests in elastic search that we know nothing about the code. Thoughts @johnynek ?

AndreasPetter commented 8 years ago

Hm... Travis tests are failing, with the note "Killed". Since they run locally and no error shows up it is not unlikely that this has something to do with https://docs.travis-ci.com/user/common-build-problems/#My-build-script-is-killed-without-any-error . How do you arrange tests at Twitter if this happens?

AndreasPetter commented 8 years ago

O.k. I had to use the shaded cassandra driver (sorry @ianoc, there seem to be dependency conflicts with the driver with the other stores), and use an embedded Cassandra version for testing. Are there any more comments?

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: ianoc
:x: AndreasPetter
You have signed the CLA already but the status is still pending? Let us recheck it.