search

twitter / storehaus

Storehaus is a library that makes it easy to work with asynchronous key value stores
Apache License 2.0
464 stars 86 forks source link

Fix flakey hbase unit tests #300

Closed BenFradet closed 8 years ago

BenFradet commented 8 years ago

fixes #294

BenFradet commented 8 years ago

I'll rebase once #299 is merged

BenFradet commented 8 years ago

I think I'll just remove the multiput property since multiput is not implemented in the hbase store.

BenFradet commented 8 years ago

I'll run the tests 10 times to see if the hbase tests are fixed

BenFradet commented 8 years ago

@johnynek ran the suites 10 times and no hbase tests failed, tell me when you want me to rebase.

johnynek commented 8 years ago

This looks great, thanks so much. If you rebase, I'll keep running the tests until elastic search passes. :(

BenFradet commented 8 years ago

Could you merge #299 first since I checked out from this branch to avoid having to go through the humongous quantity of logs? In the meantime I'll remove the unnecessary commits.

BenFradet commented 8 years ago

@johnynek done :+1:

johnynek commented 8 years ago

Thanks!