twitter / storehaus

Storehaus is a library that makes it easy to work with asynchronous key value stores
Apache License 2.0
465 stars 92 forks source link

Cleanup storehaus-caliper #314

Closed BenFradet closed 8 years ago

BenFradet commented 8 years ago

Fixes #281 Closes #307

BenFradet commented 8 years ago

As I said in #307, should we add storehausCaliper in build.sbt so that it gets compiled by travis as well?

johnynek commented 8 years ago

yeah, it would be great to at least build it in travis to prevent bitrot.

BenFradet commented 8 years ago

Ok, will do.

BenFradet commented 8 years ago

Done :+1:

johnynek commented 8 years ago

I think we need to exclude caliper from the mima check (and probably also not publish it)

BenFradet commented 8 years ago

Woops, I thought it'd get the same treatment as storehaus-testing but I didn't realize storehaus-testing was published, I'll check that out tomorrow.

BenFradet commented 8 years ago

erf maven.twttr.com 503'd during the build causing it to fail :disappointed:

johnynek commented 8 years ago

restarting the build

BenFradet commented 8 years ago

same thing happened again apparently

BenFradet commented 8 years ago

@johnynek could you trigger a new buld? Thanks.

johnynek commented 8 years ago

@BenFradet Thanks as always!