search

twitter / storehaus

Storehaus is a library that makes it easy to work with asynchronous key value stores
Apache License 2.0
465 stars 92 forks source link

Cleanup storehaus-mongodb #324

Closed BenFradet closed 8 years ago

BenFradet commented 8 years ago

ping @johnynek in case you missed it

johnynek commented 8 years ago

one minor comment (about string formatting).

I would say that maybe this code needs to be reworked. It might make sense to move it to reactivemongo http://reactivemongo.org/ which is already async and handles most of the issues here (but that is out of scope for the current PR).

BenFradet commented 8 years ago

Agreed, will tackle string formatting here and create an issue to move to reactive mongo.

BenFradet commented 8 years ago

Thanks a lot for your review, sorry if I wasn't clear enough earlier.

johnynek commented 8 years ago

👍