twitter / storehaus

Storehaus is a library that makes it easy to work with asynchronous key value stores
Apache License 2.0
464 stars 86 forks source link

Clean up build to prep for 2.12 #335

Closed sritchie closed 7 years ago

sritchie commented 7 years ago

This PR:

This should get us ready for 2.12.0 once the relevant deps are in place.

sritchie commented 7 years ago

@johnynek done!

johnynek commented 7 years ago

looks like it does not build.

sritchie commented 7 years ago

Will fix when I get on a real computer

sritchie commented 7 years ago

Okay @johnynek, NOW we should be good. That version bump killed some keys that we were importing (but not using). All tidied up now.

sritchie commented 7 years ago

Build just needed a kick, @johnynek. Good to go now when tests pass.

sritchie commented 7 years ago

Hmm, seems to be getting stuck after the kafka tests.

sritchie commented 7 years ago

Nice @johnynek... looks like that upgrade DID catch two more binary incompatibilities. We have a TON of those now, btw. Definite version bump required.

codecov-io commented 7 years ago

Current coverage is 60.17% (diff: 100%)

No coverage report found for develop at 020d92d.

Powered by Codecov. Last update 020d92d...40ae96e