Occupancy for Cache trait implementation classes

twitter / storehaus

Storehaus is a library that makes it easy to work with asynchronous key value stores

Apache License 2.0

464 stars 86 forks source link

Occupancy for Cache trait implementation classes #343

Closed ppanero closed 7 years ago

ppanero commented 7 years ago

Added a function to be able to access the cache occupancy (amount of elements) of it

ppanero commented 7 years ago

I noticed it fails with

method occupancy()Int in trait com.twitter.storehaus.cache.Cache is present only in current version

But im not sure how to fix it.

johnynek commented 7 years ago

To fix the build, add the method to this list:

https://github.com/twitter/storehaus/blob/develop/build.sbt#L28

This looks fine to me. I think there is no way around breaking binary compatibility if we want this method, and it looks like we have a lot of pending breakages.

If you get this green, I'm happy to merge.

ppanero commented 7 years ago

Had some issues in my branches etc. Closed this, squashed and PR again: https://github.com/twitter/storehaus/pull/345

Cheers