twitter / storehaus

Storehaus is a library that makes it easy to work with asynchronous key value stores
Apache License 2.0
464 stars 86 forks source link

Release 0.15.0 prep. Update version in preparation for rc release. #348

Closed pankajroark closed 7 years ago

pankajroark commented 7 years ago

Proposed release notes:

Note that this release drops support for anything before jdk8. Upstream libs finagle and util have already done so.

johnynek commented 7 years ago

seems good to me. We can also go ahead and reset the mima to not check.

Also, the next version will be 0.15.0, not 0.16.0.

pankajroark commented 7 years ago

Can you clarify about "We can also go ahead and reset the mima to not check." I'm not familiar with the procedure around mima.

codecov-io commented 7 years ago

Codecov Report

Merging #348 into develop will increase coverage by 0.43%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #348      +/-   ##
===========================================
+ Coverage    60.84%   61.27%   +0.43%     
===========================================
  Files          119      119              
  Lines         1798     1818      +20     
  Branches       110      117       +7     
===========================================
+ Hits          1094     1114      +20     
  Misses         704      704
Impacted Files Coverage Δ
.../twitter/storehaus/redis/RedisSortedSetStore.scala 73.8% <0%> (-1.81%) :arrow_down:
...scala/com/twitter/storehaus/kafka/KafkaStore.scala 95.23% <0%> (+0.23%) :arrow_up:
...ehaus/elasticsearch/ElasticSearchStringStore.scala 87.8% <0%> (+0.3%) :arrow_up:
...scala/com/twitter/storehaus/mysql/MySqlStore.scala 96.84% <0%> (+0.33%) :arrow_up:
...a/com.twitter.storehaus.leveldb/LevelDBStore.scala 94.11% <0%> (+0.36%) :arrow_up:
.../twitter/storehaus/mysql/MergeableMySqlStore.scala 91.3% <0%> (+10.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bd0991...fcaee7c. Read the comment docs.

johnynek commented 7 years ago

this list should be emptied out:

https://github.com/twitter/storehaus/blob/develop/build.sbt#L28

and this should be set to 0.15.0 after we publish.

ttim commented 7 years ago

@johnynek I thought we do next (at least I did with tormenta):

  1. set version to 0.15.0, do release, point to this commit as release commit
  2. set version to 0.15.1-snapshot, clean mima exclusions, change youngestForwardCompatible to point to 0.15.0 as subsequent PR after release.

But for tormenta we had actual release tags (and we set version in this tags with later merge them into develop). What do you think about this workflow? Should it be somehow different?

johnynek commented 7 years ago

I think your workflow is fine an less likely to cause an issue. I was assuming no one changes any code after dropping the exclusions, but indeed it is better to keep them there until we can bump the version to 0.15.1.-snapshot.

pankajroark commented 7 years ago

published 0.15.0-RC2, and updated the version in PR to 0.15.0. Waiting for this to be accepted to merge, then tag commit for 0.15.0 and publish 0.15.0 to maven.