search

twitter / storehaus

Storehaus is a library that makes it easy to work with asynchronous key value stores
Apache License 2.0
465 stars 92 forks source link

Finagle Deps are way behind the mainline. #354

Open jho opened 6 years ago

jho commented 6 years ago

We use storehaus in a bunch of places in our infrastructure. I hate to say it but we really regret the decision now since storehaus is so far behind on it's Finagle deps. Is upgrading them a possibility? I'd be willing to contribute in someway if its deemed plausible.

johnynek commented 6 years ago

Are you hitting any binary compatibility problems? You should be able to work with a later version of finagle.

We (at stripe) use storehaus with much later finagle versions without a problem, but fixing to the very latest often causes problems for users (since the APIs we touch often don't change much).

That said updating to alleviate issues should be fine.

PRs happily accepted!

jho commented 5 years ago

@johnynek Thanks for the reply! We did encoutner binary compat problems, but I wonder now if they were because of mixed finagle versions from our own diamond dependency problems. We will try upgrading more carefully and get back to you. What versions of finagle does stripe use against the latest storehaus? Thanks again for the reply! Wanted to also thank you for all the work you've done on Storehaus, Summingbird, Bijection, etc. Good stuff.

cacts commented 4 years ago

Opened #361 that updates Finagle et al to much more recent versions, the old version of netty required by older finagles was particularly problematic in other projects.