search

twitter / storehaus

Storehaus is a library that makes it easy to work with asynchronous key value stores
Apache License 2.0
464 stars 86 forks source link

Replace usage of deprecated util conversion methods. #355

Closed kevinoliver closed 5 years ago

kevinoliver commented 5 years ago

Problem

As of util commit https://github.com/twitter/util/commit/ee56e5f2418d5d6540d37268436ff6f47520edaf the conversions are deprecated.

Solution

Avoid these conversion methods.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

kevinoliver commented 5 years ago

fwiw looks like CI failed for unrelated reasons.

$ mongo mydb_test --eval 'db.addUser("travis", "test");'
MongoDB shell version v3.4.10
connecting to: mongodb://127.0.0.1:27017/mydb_test
MongoDB server version: 3.4.10
2018-12-13T22:57:17.594+0000 E QUERY    [thread1] TypeError: db.addUser is not a function :
@(shell eval):1:1
The command "mongo mydb_test --eval 'db.addUser("travis", "test");'" failed and exited with 252 during .
dieu commented 5 years ago

@kevinoliver could you rebase on latest develop?

dieu commented 5 years ago 
[info] Compiling 16 Scala sources to /home/travis/build/twitter/storehaus/storehaus-core/target/scala-2.11/test-classes...
[error] /home/travis/build/twitter/storehaus/storehaus-core/src/test/scala/com/twitter/storehaus/RetryingReadableStoreProperties.scala:41: not found: value Duration
[error]         backoffs = for (i <- 0 until 3) yield Duration.fromMilliseconds(1)
[error]

@kevinoliver compilation is falling.

dieu commented 5 years ago

@kevinoliver thanks for your PR.