search

twitter / summingbird

Streaming MapReduce with Scalding and Storm
https://twitter.com/summingbird
Apache License 2.0
2.14k stars 267 forks source link

make cosmetic changes in Build.scala #600

Closed adamkozuch closed 9 years ago

adamkozuch commented 9 years ago

I noticed that there is no ScalaTest in dependencies. Probably it will be used in future tests so I add it. Also I made small cosmetic changes in Build file. Is it OK?

ianoc commented 9 years ago

Cosmetic changes look good, not sure why you added the scalatest, is it being used now? or you think it just will be in future?

adamkozuch commented 9 years ago

I just noticed that there is a val with version of ScalaTest but there is no dependency. I figure it out that it will be used in future. Should I remove it for now?

ianoc commented 9 years ago

Yes i think that would be best, remove both for now

adamkozuch commented 9 years ago

Done.

ianoc commented 9 years ago

looks like a legit test failure:

[error] /home/travis/build/twitter/summingbird/project/Build.scala:46: commonsLangVersion is already defined as value commonsLangVersion
[error]   val commonsLangVersion ="2.6";
[error]       ^
[error] one error found
[error] (compile:compile) Compilation failed
adamkozuch commented 9 years ago

Sorry for that. Now it should be OK

johnynek commented 9 years ago

Can you merge with develop? The tests should be green now. Sorry for the issues.

johnynek commented 9 years ago

Thank you for your help!