search

twitter / summingbird

Streaming MapReduce with Scalding and Storm
https://twitter.com/summingbird
Apache License 2.0
2.14k stars 267 forks source link

MergeableStoreFactory extends java.io.Serializable #616

Closed egonina closed 9 years ago

egonina commented 9 years ago

This was breaking serialization internally, adding fix

johnynek commented 9 years ago

sorry we missed this. Generally all our traits need this. :/ Merge when green.

egonina commented 9 years ago

Had to exclude two targets from summingbird-example to get this to pass, but the build is green now

johnynek commented 9 years ago

I guess we can merge this. It may hit someone externally later if they don't explicitly add this stuff back, perhaps.