search

twitter / summingbird

Streaming MapReduce with Scalding and Storm
https://twitter.com/summingbird
Apache License 2.0
2.14k stars 267 forks source link

bisectingMinify is too strict #618

Closed johnynek closed 8 years ago

johnynek commented 9 years ago

https://github.com/twitter/summingbird/blob/develop/summingbird-scalding/src/main/scala/com/twitter/summingbird/scalding/ScaldingPlatform.scala#L121

At that point we could do this:

  // no need to minify if we can read this source correctly:
  case (_, source) if Try(source.validateTaps(mode)).isSuccess => Right(desired)
  case _ => bisectingMinify(...