search

twitter / summingbird

Streaming MapReduce with Scalding and Storm
https://twitter.com/summingbird
Apache License 2.0
2.14k stars 267 forks source link

Remove duplication of Options resolving #636

Closed johnynek closed 8 years ago

johnynek commented 8 years ago

https://github.com/twitter/summingbird/blob/develop/summingbird-storm/src/main/scala/com/twitter/summingbird/storm/StormPlatform.scala#L129

and

https://github.com/twitter/summingbird/blob/develop/summingbird-scalding/src/main/scala/com/twitter/summingbird/scalding/ScaldingPlatform.scala#L274

are duplicating logic on how to find options from an ordered list of names. They could get out of sync. We should find a way to share the same logic.

johnynek commented 8 years ago

closed by #635