search

twitter / summingbird

Streaming MapReduce with Scalding and Storm
https://twitter.com/summingbird
Apache License 2.0
2.14k stars 267 forks source link

Add a test for redundant also in Memory platform #638

Closed johnynek closed 8 years ago

johnynek commented 8 years ago

I tried to reproduce #631 but could not.

I wonder if this was actually user error, and we didn't notice.

I guess we should add this test, but it already passes.

Fixed a warning of a missing case match in MemoryPlatform, but we're not testing flatMapValues, obviously, since it has never been triggered.

ianoc commented 8 years ago

LGTM, I had a quick question, but not a blocker, won't merge to make sure you see it. But feel free to merge.

johnynek commented 8 years ago

I'll merge because it is better to have a test, even though it does not seem to expose any issue.