twitter / summingbird

Streaming MapReduce with Scalding and Storm
https://twitter.com/summingbird
Apache License 2.0
2.14k stars 267 forks source link

Incorporate latest storehaus release #665

Closed pankajroark closed 8 years ago

pankajroark commented 8 years ago

Corresponding changes to changes in FutureCollector type signature.

rubanm commented 8 years ago

@pankajroark Looks like some tests are failing on travis There has been no public 0.10.0 release (only RCs) so we may not strictly need to change to 0.11.0-SNAPSHOT, but it doesn't hurt I guess.

pankajroark commented 8 years ago

Fixed tests. Storehaus depends on latest versions of finagle and util, updated those. Example project was failing due to some excludes. I've removed those excludes. Not sure what the excludes were meant for but don't seem to be needed now.

rubanm commented 8 years ago

👍

johnynek commented 8 years ago

looks like this was added here:

https://github.com/twitter/summingbird/commit/4a80201c9b30d2dd9d034e898df8f0fb6b4f8ebc

@egonina do you remember why it was added?