Closed johnynek closed 7 years ago
:thumbsup:
well our terrible tests strike again.
This PR passes tests locally for me, but we are see OOM it looks like. This is such a trivial change, it if compiles, it almost has to be correct. Really hard to see how it could really cost more memory.
We need to really figure something out here.
Mima is also failing btw
Oh yeah. Of course this takes a different type but actually the previous type was a bug (and hopefully on one actually created one of those themselves). On Wed, Jan 11, 2017 at 18:06 Pankaj Gupta notifications@github.com wrote:
Mima is also failing btw
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/twitter/summingbird/pull/706#issuecomment-272071084, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEJdsjIrdMC2JowvW0Wnb7ZFQJ54uh9ks5rRaaygaJpZM4LhLGL .
Yeah, the type change looks ok.
our tests are so terrible.
Maybe when we upgrade storm we can finally have less flakiness.
We also need to suppress logs in the test output. Somehow the code we have for that isn't working.
@pankajroark look good?