piyushnarang commented 7 years ago

Noticed that the Algebird bump broke SB in a couple of places. We might need to also bump Scalding as part of this (which I can do when we have a release out).

codecov-io commented 7 years ago

Codecov Report

Merging #715 into develop will increase coverage by 0.11%. The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #715      +/-   ##
===========================================
+ Coverage    70.84%   70.96%   +0.11%     
===========================================
  Files          141      141              
  Lines         3471     3468       -3     
  Branches       195      195              
===========================================
+ Hits          2459     2461       +2     
+ Misses        1012     1007       -5

Impacted Files	Coverage Δ
.../twitter/summingbird/scalding/VersionedState.scala	`0% <ø> (ø)`	:white_check_mark:
...cala/com/twitter/summingbird/batch/TimeStamp.scala	`62.85% <ø> (+6.1%)`	:white_check_mark:
.../scala/com/twitter/summingbird/batch/BatchID.scala	`81.08% <100%> (ø)`	:white_check_mark:
...la/com/twitter/summingbird/scalding/TestUtil.scala	`49.12% <ø> (+1.75%)`	:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 476d58e...e0eb39b. Read the comment docs.

piyushnarang commented 7 years ago

@pankajroark / @johnynek / @ttim - please take a look when you can, thanks.

johnynek commented 7 years ago

👍

johnynek commented 6 years ago

looks like develop already has this. closing.

twitter / summingbird

Summingbird changes for Algebird 0.13.0 #715

Codecov Report