Closed johnynek closed 7 years ago
cc @non a few of the things we hit the other day.
storm platform flaked. Rerunning.
@pankajroark can I get a review of this?
@pankajroark what do you think?
Looks like the storm tests are almost never passing at this point. I have rerun them over and over and I don't see how this change could have broken just them on 2.11 (maybe?)
(they pass locally)
This change doesn't look related to fails. I think it's safe to merge it.
Merging #716 into develop will increase coverage by
0.03%
. The diff coverage is78.57%
.
@@ Coverage Diff @@
## develop #716 +/- ##
===========================================
+ Coverage 70.84% 70.88% +0.03%
===========================================
Files 141 141
Lines 3471 3479 +8
Branches 195 202 +7
===========================================
+ Hits 2459 2466 +7
- Misses 1012 1013 +1
Impacted Files | Coverage Δ | |
---|---|---|
.../scala/com/twitter/summingbird/batch/BatchID.scala | 83.72% <100%> (+2.63%) |
:white_check_mark: |
...summingbird/scalding/batch/BatchedOperations.scala | 46.15% <33.33%> (-7.7%) |
:x: |
.../scala/com/twitter/summingbird/batch/Batcher.scala | 64.06% <66.66%> (-0.46%) |
:x: |
...la/com/twitter/summingbird/scalding/TestUtil.scala | 49.12% <0%> (+1.75%) |
:white_check_mark: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 476d58e...4df3d02. Read the comment docs.
Fix an old todo (by removing a duplicate method), and add support for Successible and Predecessible typeclasses (which are interesting for working with Bounded).