Closed ttim closed 7 years ago
lgtm
Merging #723 into develop will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #723 +/- ##
========================================
Coverage 70.93% 70.93%
========================================
Files 141 141
Lines 3475 3475
Branches 201 201
========================================
Hits 2465 2465
Misses 1010 1010
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ab747e6...84cb76e. Read the comment docs.
During upgrade to Storm 1.0.x API (https://github.com/twitter/summingbird/pull/699) we broke log levels in our storm tests. There are two reasons for that:
log4j2
, and therefore we need to excludelog4j-over-slf4j
andlog4j-slf4j-impl
( which is kindaslf4j-over-log4j2
) from our tests classpath.This PR fix both issues.